Id #

Review Date

Developer

Review Participants

Program/Object Name

Program/Object Desc.

SECTION I:  Naming Conventions

Comments

Y/N

Are local parameters for the subroutine named correctly (Rx_)?

Are local variables within the subroutine named correctly (V_, T_, etc)?

Are naming standards followed for all new objects?

Are standard Includes used when possible?

Are the appropriate message classes and types used?

Are the parameters and subroutine names descriptive?

SECTION II:  Programming Standards

Comments

Y/N

Are variables used only within the subroutine defined locally versus globally?

Are all ‘global’ variables passed as parameters into the subroutine?

Are all the parameters for the subroutine listed and described in the header?

Are the keywords TABLES, USING, and CHANGING used when performing subroutines?

In the FORM statement for the subroutine, are the parameters that the keywords TABLES, USING VALUE, and CHANGING used?

If a subroutine was executed in more than one program, did you create a function module?

Is the program made to be modular wherever suitable?

Is proper spacing, indentation and uppercase keywords used to ensure code readability?

Is the Program/Object documentation (program header and comments) sufficient & does it follow Development Standards?

If this is a modification, did you document the changed lines with the Change Number?

SECTION II:  Programming Standards

Comments

Y/N

If this program was cloned or modified, did you comment out the original SAP code?

Did you use Append Structures to extend SAP objects?

When defining variables did you use the ‘LIKE’ parameter?

Did you avoid the use of hard coding throughout your Program/Object?

Did you use 4.0 notation for defining internal tables?

Have Function Modules and Groups been documented to promote future reuse?

SECTION III:  Process Steps

Comments

Y/N

Does the code match the HLD and Tech Spec?

Is the Unit Test Plan attached?

Is the Test Data attached?

Did you check run-time analysis (SE30)?

Has an extended check been made on the program and in all menu interfaces (Program/Check/Extended Check)?

SECTION IV:  Programming Guidelines

Comments

Y/N

Does the order of your declarations, events and subroutines follow standards?

Did you use the standard report header?.

Were the compare operators ( =, >, <, <>) used?

Did you use the proper program attributes?

Did you incorporate the proper security based on the requirements?

Did you avoid the use of native SQL?

Did you adhere to the “Performance Guidelines”?

SECTION V:  Multi-Lingual Program Support

Comments

Y/N

Did you use Text Elements for all literal text?

Did you avoid the use of multiple text elements to generate one large text value?

SECTION V:  Multi-Lingual Program Support

Comments

Y/N

Did you use the AS TEXT statement within SORT statements?

Did you use text elements or report titles to define your list headings?

Did you define all text descriptions within language dependent tables?

SECTION VI:  Documentation

Comments

Y/N

If an OSS Note, is the OSS Note Tracking spreadsheet updated?

Any exceptions to standards are documented in the comments of the object?

SECTION VII:  Comments/Notes

SECTION VIII:  Code Walkthrough Approvals

Development Lead:

Date:

Developer:

Date: